Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place all info/success messages in flash #82

Open
victorbrender opened this issue Dec 1, 2016 · 3 comments
Open

Place all info/success messages in flash #82

victorbrender opened this issue Dec 1, 2016 · 3 comments
Assignees

Comments

@victorbrender
Copy link
Collaborator

victorbrender commented Dec 1, 2016

Use https://www.npmjs.com/package/express-flash
@chill117 Can you confirm that this package should be used to implement flash in the application? Thank you!

@chill117
Copy link
Member

chill117 commented Dec 2, 2016

@victorbrender No, I wouldn't use that module because it hasn't been maintained for 3 years. Flash messages are actually pretty simple. I don't think it would be too difficult to implement this without a module.

@bokova
Copy link
Collaborator

bokova commented Jan 9, 2017

@chill117 "Place all info..." - would help if the task was more specific as to what exactly should be in a flash message

@victorbrender
Copy link
Collaborator Author

Flash messages proposal:

  • After login -> You have successfully logged in as 'Stan Marsh'
  • After logout -> You have successfully logged out
  • After successfully creating a project -> You have successfully created project 'Acme'
  • After successfully editing a project -> Project 'Acme' was successfully updated
  • After an error while editing a project -> There was an error while updating project 'Acme'
  • After deleting a project -> Project 'Acme' was deleted
  • After successfully editing your profile -> Your profile was successfully updated
  • After an error while editing your profile -> There was an error while updating your profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants