Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up home.js #108

Open
karliatto opened this issue Jan 23, 2017 · 1 comment
Open

clean up home.js #108

karliatto opened this issue Jan 23, 2017 · 1 comment

Comments

@karliatto
Copy link
Member

The variable loggedMessage is never used

var loggedMessage = 'You are logged'; 

It is located in Line 9 and Line 24 but is not anymore used in home.html.

https://github.com/Learn-by-doing/bitstarter/blob/master/controllers/home.js#L9

https://github.com/Learn-by-doing/bitstarter/blob/master/controllers/home.js#L24

@drurenia
Copy link
Contributor

drurenia commented Jan 30, 2017

I've changed it even though I was not aware of this issue. The clean up will be merged as soon as the pull request #109 is accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants