Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API inconsistency: some SUNDIALS "Space" functions use sunindextype and some use long int #423

Open
balos1 opened this issue Feb 16, 2024 · 5 comments
Assignees

Comments

@balos1
Copy link
Member

balos1 commented Feb 16, 2024

For example, we have

N_VSpace(N_Vector x, sunindextype *lenrw, sunindextype *leniw);
SUNMatSpace(SUNMatrix A, long  int *lenrw, long int *liniw);
@balos1 balos1 added the bug label Feb 16, 2024
@balos1
Copy link
Member Author

balos1 commented Feb 16, 2024

This is sort of related to conversation in #409. We use long in many places where we should now switch to either long long or a fixed-width type like int64_t since we are now requiring C99. However, in this case I think we want to use sunindextype.

@gardner48
Copy link
Member

gardner48 commented Feb 16, 2024

The use of sunindextype in N_VSpace was an erroneous change when sunindextype was added. It would be good to address in 7.0 (at least for consistency).

@balos1
Copy link
Member Author

balos1 commented Feb 17, 2024

Looks like sunindextype is used for ARKodeButcherTable_Space too.

@balos1
Copy link
Member Author

balos1 commented Mar 29, 2024

This was fixed in 7.0

@balos1 balos1 closed this as completed Mar 29, 2024
@balos1 balos1 modified the milestones: SUNDIALS Next, SUNDIALS v7.0.0 Mar 29, 2024
@balos1
Copy link
Member Author

balos1 commented Mar 29, 2024

Actually, I was mistaken, this was not fixed in 7.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants