From c38cabd8148155a3294621099264551f235d7dea Mon Sep 17 00:00:00 2001
From: Kevin Jump <kevin@thejumps.co.uk>
Date: Wed, 4 Oct 2023 15:05:45 +0100
Subject: [PATCH] Add comments to remove build warnings.

---
 .../SyncHandlers/Handlers/ContentHandler.cs           |  1 +
 .../SyncHandlers/Handlers/MediaHandler.cs             |  1 +
 uSync.BackOffice/SyncHandlers/SyncHandlerBase.cs      |  1 +
 uSync.BackOffice/SyncHandlers/SyncHandlerRoot.cs      | 11 +++++++++++
 .../Serializers/ContentSerializerBase.cs              |  7 ++++++-
 5 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/uSync.BackOffice/SyncHandlers/Handlers/ContentHandler.cs b/uSync.BackOffice/SyncHandlers/Handlers/ContentHandler.cs
index b698b265..e12efcf8 100644
--- a/uSync.BackOffice/SyncHandlers/Handlers/ContentHandler.cs
+++ b/uSync.BackOffice/SyncHandlers/Handlers/ContentHandler.cs
@@ -58,6 +58,7 @@ public ContentHandler(
             this.serializer = syncItemFactory.GetSerializer<IContent>("ContentSerializer");
         }
 
+        /// <inheritdoc />
         protected override bool HasChildren(IContent item)
             => contentService.HasChildren(item.Id);
 
diff --git a/uSync.BackOffice/SyncHandlers/Handlers/MediaHandler.cs b/uSync.BackOffice/SyncHandlers/Handlers/MediaHandler.cs
index a4304a3b..49fbd247 100644
--- a/uSync.BackOffice/SyncHandlers/Handlers/MediaHandler.cs
+++ b/uSync.BackOffice/SyncHandlers/Handlers/MediaHandler.cs
@@ -51,6 +51,7 @@ public MediaHandler(
             this.mediaService = mediaService;
         }
 
+        /// <inheritdoc />
         protected override bool HasChildren(IMedia item)
             => mediaService.HasChildren(item.Id);
 
diff --git a/uSync.BackOffice/SyncHandlers/SyncHandlerBase.cs b/uSync.BackOffice/SyncHandlers/SyncHandlerBase.cs
index ff927d5e..c9d8b2e3 100644
--- a/uSync.BackOffice/SyncHandlers/SyncHandlerBase.cs
+++ b/uSync.BackOffice/SyncHandlers/SyncHandlerBase.cs
@@ -54,6 +54,7 @@ public SyncHandlerBase(
             this.entityService = entityService;
         }
 
+        /// <inheritdoc />
         protected override bool HasChildren(TObject item)
             => entityService.GetChildren(item.Id).Any();
 
diff --git a/uSync.BackOffice/SyncHandlers/SyncHandlerRoot.cs b/uSync.BackOffice/SyncHandlers/SyncHandlerRoot.cs
index 809eae14..6cec4a31 100644
--- a/uSync.BackOffice/SyncHandlers/SyncHandlerRoot.cs
+++ b/uSync.BackOffice/SyncHandlers/SyncHandlerRoot.cs
@@ -881,6 +881,13 @@ virtual public IEnumerable<uSyncAction> Export(TObject item, string folder, Hand
             return uSyncActionHelper<XElement>.SetAction(attempt, filename, GetItemKey(item), this.Alias).AsEnumerableOfOne();
         }
 
+        /// <summary>
+        ///  does this item have any children ? 
+        /// </summary>
+        /// <remarks>
+        ///  on items where we can check this (quickly) we can reduce the number of checks we might 
+        ///  make on child items or cleaning up where we don't need to. 
+        /// </remarks>
         protected virtual bool HasChildren(TObject item)
             => true; 
 
@@ -1783,6 +1790,10 @@ private string GetNameFromFileOrNode(string filename, XElement node)
             => !string.IsNullOrWhiteSpace(filename) ? filename : node.GetAlias();
 
 
+        /// <summary>
+        ///  get thekey for any caches we might call (thread based cache value)
+        /// </summary>
+        /// <returns></returns>
         protected string GetCacheKeyBase()
             => $"keycache_{this.Alias}_{Thread.CurrentThread.ManagedThreadId}";
 
diff --git a/uSync.Core/Serialization/Serializers/ContentSerializerBase.cs b/uSync.Core/Serialization/Serializers/ContentSerializerBase.cs
index b384f6b3..c85d7160 100644
--- a/uSync.Core/Serialization/Serializers/ContentSerializerBase.cs
+++ b/uSync.Core/Serialization/Serializers/ContentSerializerBase.cs
@@ -641,7 +641,12 @@ protected uSyncChange HandleSortOrder(TObject item, int sortOrder)
             return null;
         }
 
-        protected abstract uSyncChange HandleTrashedState(TObject item, bool trashed, Guid restoreParent);
+        [Obsolete("Pass in a restore guid for the parent - should relationships be missing")]
+        protected virtual uSyncChange HandleTrashedState(TObject item, bool trashed)
+            => uSyncChange.NoChange($"Member/{item.Name}", item.Name);
+
+        protected virtual uSyncChange HandleTrashedState(TObject item, bool trashed, Guid restoreParent)
+            => uSyncChange.NoChange($"Member/{item.Name}", item.Name);
 
         protected string GetExportValue(object value, IPropertyType propertyType, string culture, string segment)
         {