Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removevredundancy is very slow #42

Open
bqi343 opened this issue Mar 19, 2023 · 0 comments
Open

removevredundancy is very slow #42

bqi343 opened this issue Mar 19, 2023 · 0 comments

Comments

@bqi343
Copy link
Contributor

bqi343 commented Mar 19, 2023

After #40 is resolved, calling chull on 1000 points on the unit sphere takes less than 0.02s, but doing the same using

p = polyhedron(v, QHull.Library())
# Removing redundant points, i.e. points which are in the interior of the convex hull
removevredundancy!(p)
# Show remaining points, i.e. the non-redundant ones
@show vrep(p)
# Show the H-representation, the facets describing the polytope
@show hrep(p)

takes more than 5s due to this line taking time quadratic in the number of half-spaces just to remove duplicate half-spaces:

hnored = Polyhedra.removeduplicates(h, Polyhedra.OppositeMockOptimizer)

Is there a version of removeduplicates that runs in near-linear time?

@bqi343 bqi343 changed the title remove duplicates is very slow removevredundancy is very slow Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant