[FEATURE] Mitigate Boilerplate for GenerateDatabaseDetails
#50
Labels
enhancement
New feature or request
help wanted
Extra attention is needed
moderate
Issue of moderate difficulty
Currently,
GenerateDatabaseDetails
is a bespoke boilerplate function that could be significantly simplified. I think what we could do is break up the function as it stands like this:Into something like this:
Basically, the function
GenerateDatabaseDetails
should accept as an object aDBConnect
object that comes fromDBConnector.jl
. This object should contain information about the type of connection that was made (was it asqlite
connection?PostgreSQL
connection?) andGenerateDatabaseDetails
should then be able to internally set the flavor of SQL being used. Additionally,GenerateTables
can be deprecated -- I'll detail that in another issue.However,
GenerateDatabaseDetails
can still provide additional arguments likeschema
,SQL_type
, etc in case someone needs additional configuration options in the future. But in my mind, this reduces complexity significantly.The text was updated successfully, but these errors were encountered: