-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance with fixedrate=true
#47
Comments
Hint: the fixed recurrence rate |
This might be a solution: https://discourse.julialang.org/t/package-for-approximate-small-quantiles/20046/2 Drawbacks: possibly heavy dependencies, instability (the Windows build of OnlineStats is persistently failing for 32-bits); in addition the calculation of the quantiles is not exact but approximate, and needs to set a parameter for the approximation, so the implementation is not straightforward. So, although it is a solution that may deserve to be taken into account, it needs time to be analyzed. So we can leave it for version 2.0 if suitable (it would imply breaking changes in my opinion). |
Hm,,,, I must admit I find it difficult justify adding OnlineStats just for this. I'd much rather just document the possibility. Our heaviest dependency so far is NearestNeighbors which only depends on StaticArrays and is pure Julia (so it is in fact a quite light dependency). I have to say I am very happy with how low we have kept the dependencies on this package. I think this is a great benefit and I vote to keep it this way. I have been following some discussions in the Julia forums and some parties have made it clear that to install packages they have to pass through a screening of some sorts. And for that case each dependency matters significantly. |
I strongly agree! In particular for a starting user, each additional package that needs to be installed is a challenge for the patience of the user. He/She would just like to start quickly and not be bothered with installing again and again additional packages.
… Am 24.01.2019 um 23:02 schrieb George Datseris ***@***.***>:
Hm,,,, I must admit I find it difficult justify adding OnlineStats just for this. I'd much rather just document the possibility.
Our heaviest dependency so far is NearestNeighbors which only depends on StaticArrays. I have to say I am very happy with how low we have kept the dependencies on this package. I think this is a great benefit and I vote to keep it this way.
I have been following some discussions in the Julia forums and some parties have made it clear that to install packages they have to pass through a screening of some sorts. And for that case each dependency matters significantly.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#47 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7WkDAiffIJLCns4fCBhnw3TVipXByiks5vGi2OgaJpZM4aG5Ob>.
|
In the calculation of recurrence matrices with fixed recurrence rate there is the issue commented in #46 (indirectly calling
distancematrix
, which is expensive):RecurrenceAnalysis.jl/src/matrices.jl
Lines 220 to 222 in 2961a32
A function that gives the same result as
quantile(distancematrix(x,y), ε)
without callingdistancematrix
would help.Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: