Error codes

[rightaway]

Error messages like Socks4 Proxy rejected incoming bound connection - Failed could change and are concatenated from 2 different parts sometimes like ERRORS.Socks4ProxyRejectedIncomingBoundConnection and Socks4Response[data[1]]

socks/src/client/socksclient.ts

Line 566 in 6c777c2

this.closeSocket(

To do error handling we would need to do string manipulation on error.message which isn't reliable. It will be better if we could have error.code and error.detail property if the error has detail information in addition to human readable error.message.

/* with detail */
{
    code: "SOCKS4_REJECTED_INCOMING",
    detail: "Failure",
    message: "Socks4 Proxy rejected incoming bound connection - Failure"
}

/* without detail */
{
    code: "INTERNAL_ERROR",
    message: "SocksClient internal error (this should not happen)"
}

[JoshGlazebrook]

Seems reasonable, I'll try to get this done soon!

[rightaway]

Could you also add a boolean property such as error.fatal whether the error can be retried or not? Some errors like server errors can be retried but others like client errors mean something is wrong in the configuration and retrying won't help until the problem is fixed. This property will make better error handling possible.

/* client */
{
    code: "INVALID_DESTINATION_HOST",
    message: "An invalid destination host was provided.",
    fatal: true
}

/* server */
{
    code: "SOCKS4_REJECTED_INCOMING",
    detail: "Failure",
    message: "Socks4 Proxy rejected incoming bound connection - Failure",
    fatal: false
}

Are some errors in https://github.com/JoshGlazebrook/socks/blob/master/src/common/constants.ts not being thrown? I see about half of them being used in https://github.com/JoshGlazebrook/socks/blob/master/src/client/socksclient.ts.

[rightaway]

Seems reasonable, I'll try to get this done soon!

@JoshGlazebrook Do you think you would be able to add these?