Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enrich handshake to allow to return node version (like 8.9.4 or 9.0.0) and commit hash #4905

Open
amesgen opened this issue Jul 3, 2024 · 0 comments
Labels
handshake Issues/PRs related to the handshake negotation

Comments

@amesgen
Copy link
Member

amesgen commented Jul 3, 2024

Motivation

In order to estimate the rollout of a particular node version (which eg includes a certain bug fix), it would be convenient to query this information from nodes in the network (think SPO relays).

Additionally, this allows users delegating to an SPO to check whether they have already upgraded to a particular node version (assuming they trust them enough to at least not misreport this version).

Any such mechanism can be faked, so it should only be used for informational purposes, or together with an estimation of how many nodes are honest.

Implementation

Guarded behind a new NodeToNodeVersion (experimental at first), the handshake miniprotocol should be enriched to allow to return the node version (a three component version like 8.9.4 or 9.0.0)) and the git hash. These will have to be passed down from the node.

@coot coot added the handshake Issues/PRs related to the handshake negotation label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
handshake Issues/PRs related to the handshake negotation
Projects
Status: No status
Development

No branches or pull requests

2 participants