Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce PeerSelectionCounters in PeerSelectionState record #4856

Open
crocodile-dentist opened this issue Apr 22, 2024 · 1 comment
Open
Labels
outbound-governor Issues / PRs related to outbound-governor

Comments

@crocodile-dentist
Copy link
Contributor

A few monitoring activities (eg. jobPromoteColdPeer, etc) performed by the peer selection governor make a call to peerSelectionStateToCounters function whose result is used directly for tracing purposes. The main governor loop is again recalculating all results. PeerSelectionState record could be augmented with PeerSelectionCounters record, so that the results from the monitoring job could be re-used.

@crocodile-dentist crocodile-dentist added the outbound-governor Issues / PRs related to outbound-governor label Apr 22, 2024
@coot
Copy link
Contributor

coot commented May 11, 2024

Instead of augmenting the state with an additional field, I think it's better to just pass PeerSelectionCounters to the actions as an argument. This will be enough to make sure things are not reevaluated, and we don't clutter the state with extra cache-like fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
outbound-governor Issues / PRs related to outbound-governor
Projects
Status: No status
Development

No branches or pull requests

2 participants