Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve DELEG predicate failures #4655

Open
lehins opened this issue Sep 30, 2024 · 1 comment
Open

Improve DELEG predicate failures #4655

lehins opened this issue Sep 30, 2024 · 1 comment
Assignees
Labels
dijkstra Ledger era that will follow after Conway

Comments

@lehins
Copy link
Collaborator

lehins commented Sep 30, 2024

DELEG rule contains a predicate failure IncorrectDepositDELEG that doesn't report enough information and is overused. We need to add two new predicate failures that will not only report the expected value using the Mismatch type from #4649, but will also report different predicate for mismatched deposit vs refund. This has to be done only at protocol version 10, so branching on bootstrapPhase, in order not to break Node-To-Client protocol.

@lehins lehins added conway intra-era-hardfork A task that requires an intra-era hard fork labels Sep 30, 2024
@aniketd aniketd added this to Conway Oct 2, 2024
@github-project-automation github-project-automation bot moved this to To do in Conway Oct 2, 2024
@lehins lehins added dijkstra Ledger era that will follow after Conway and removed conway intra-era-hardfork A task that requires an intra-era hard fork labels Oct 15, 2024
@lehins
Copy link
Collaborator Author

lehins commented Oct 15, 2024

This has been postponed until next era, unless we decide that we will have another intra-era hardfork that advances Conway era to PV11

@lehins lehins removed this from Conway Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dijkstra Ledger era that will follow after Conway
Projects
None yet
Development

No branches or pull requests

2 participants