Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] - Remove usages of SafeHash #952

Open
palas opened this issue Oct 25, 2024 · 0 comments
Open

[MAINTENANCE] - Remove usages of SafeHash #952

palas opened this issue Oct 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@palas
Copy link
Contributor

palas commented Oct 25, 2024

What

Replace all usages of SafeHash with unverified Hash unless in cases where it is possible to track the source of the hash. If somewhere this is unavoidable, wait till the last second before unsafely converting to SafeHash.

Why

SafeHash is meant to encode that the hash has a pre-image, but this is not enforceable most of the time in practice, since both cardano-cli and cardano-api are often provided with the hash only, not with the pre-image.

Acceptance Criteria

  • There are no unsafe creations of SafeHash with the possible exception of just before interfaces with modules down the stack if unavoidable.
@palas palas added the enhancement New feature or request label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant