Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop pyrealm.core.solar function radiation calc library #236

Closed
Tracked by #322
j-emberton opened this issue May 22, 2024 · 1 comment · Fixed by #237 · May be fixed by #245
Closed
Tracked by #322

Develop pyrealm.core.solar function radiation calc library #236

j-emberton opened this issue May 22, 2024 · 1 comment · Fixed by #237 · May be fixed by #245
Assignees

Comments

@j-emberton
Copy link
Collaborator

j-emberton commented May 22, 2024

Proposal to breakout individual solar radiation calc functions from pyrealm.splash.solar and make these available in pyrealm.core.solar

Alternatives
Alternative would be to try and find an existing Python library to provide similar functionality and then write custom functions for any missing features such as calculation of ppfd and calculation of radiation for sub-daily intervals..
Seeing as we already have much of the code we need in Pyrealm, we might as well reuse it.

Additional context
This is in support of implementing the two-leaf canopy model

@davidorme
Copy link
Collaborator

In particular, the existing code in pyrealm handles array inputs, where other libraries tend to be more focussed on single locations.

@j-emberton j-emberton self-assigned this May 22, 2024
@j-emberton j-emberton linked a pull request May 22, 2024 that will close this issue
7 tasks
@MarionBWeinzierl MarionBWeinzierl moved this to Priorities and low hanging fruit in ICCS development board May 23, 2024
@MarionBWeinzierl MarionBWeinzierl moved this from Priorities and low hanging fruit to In Progress in ICCS development board May 23, 2024
@j-emberton j-emberton moved this from In Progress to Review in ICCS development board Jul 25, 2024
@j-emberton j-emberton moved this from Review to In Progress in ICCS development board Oct 17, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in ICCS development board Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment