Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect domain validation #950

Open
StuBz211 opened this issue Feb 7, 2024 · 1 comment
Open

Incorrect domain validation #950

StuBz211 opened this issue Feb 7, 2024 · 1 comment
Labels
bug

Comments

@StuBz211
Copy link

StuBz211 commented Feb 7, 2024

Incorrect domain validation since 2013 68ab79f
(spaces between 1 in regular expression- it's a first problem)

Code Version

7.5.0

Expected Behavior

Domain's validating success

Current Behavior

regexp doesn't work

Possible Solution

To update validation domain regexp

Steps to Reproduce

from saml2.validate import valid_domain_name

valid_domain_name('simple.domain.com')

and getting an error ValueError("Not a proper domain name")
StuBz211 pushed a commit to StuBz211/pysaml2 that referenced this issue Feb 7, 2024
bugfix: domain name validation.
303c760 
Updated regexp for domain validation
Add testcases for domain validation

fix issue: IdentityPython#950
@StuBz211 StuBz211 mentioned this issue Feb 7, 2024
Open
@StuBz211
Copy link
Author

StuBz211 commented Feb 7, 2024

Fix is coming folks!
#951

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c00kiemon5ter @StuBz211