Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex Need to be modified #2

Open
uganjha opened this issue Mar 15, 2016 · 2 comments
Open

Regex Need to be modified #2

uganjha opened this issue Mar 15, 2016 · 2 comments

Comments

@uganjha
Copy link

uganjha commented Mar 15, 2016

CSVRE.java has issue

*""([^\"]+?)",?|([^,]+),?|," * reg-ex can not match occurrence where if any column of csv has no value.

Like ,,,,,"0",,"0","0",,,"12/13/2015 12:10:00 AM","2.94","12/13/2015 12:10:00 AM","13.69"

so it should be ""([^\"]?)",?|([^,]),?|,"
@IanDarwin
Copy link
Owner

Thanks. Busy with Android Cookbook now, will get this tested and installed after that.

@IanDarwin
Copy link
Owner

Did you run the tests? Your change breaks a bunch of CSVRETests, not just the one with the empty field, so I think it's not as simple as your first attempt. Maybe a non-greedy match will be better?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IanDarwin @uganjha