New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEL_LAYER_HEIGHT in simulate_3d #237

Open

faberno opened this issue Aug 15, 2023 · 0 comments · May be fixed by #252

Labels

bug good first issue

Collaborator

faberno commented Aug 15, 2023

Describe the bug
Simulate_3D does not pad the arrays with the gel layer, but still the element_pos accounts for it

simpa/simpa/core/simulation_modules/acoustic_forward_module/simulate_3D.m

Line 103 in 6278d01

elem_pos(1, :) = elem_pos(1, :) - 0.5 * kgrid.x_size + dx * GEL_LAYER_HEIGHT;

faberno added the bug label

kdreher added the good first issue label

faberno linked a pull request

that will close this issue

removed gel_layer_height in simulate_3D.m #252

Open

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment