Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment tracking to examples #18

Closed
mdahlhausen opened this issue Oct 23, 2015 · 7 comments
Closed

add comment tracking to examples #18

mdahlhausen opened this issue Oct 23, 2015 · 7 comments

Comments

@mdahlhausen
Copy link
Member

@mostaphaRoudsari do you think we should add comments to each of the examples? It'll be easy to add a Disqus comment chain to each example.

@mostaphaRoudsari
Copy link
Member

Hi @mdahlhausen. It's not clear to me how to add it to the page but that would be a huge move forward. How does it work? Are they going to take care of keeping the comments? Will it be different for each page address? I'm asking since Hydra is a single page application. Can we have different discussion/commenting for the same page with different hashes?
I'm going to modify the code to use pushState or location.hash for different users. That might also help for this purpose.

@mdahlhausen
Copy link
Member Author

@mostaphaRoudsari . I'll test it out offline before I push it live, but disqus handles comments by the unique url, so I think we'll be fine. I'll work on it later this week.

@mostaphaRoudsari
Copy link
Member

Nice! I'm working on #2 and #15.

@mdahlhausen
Copy link
Member Author

Added comments with this commit. There is a separate comment thread for each example.

@mostaphaRoudsari
Copy link
Member

@mdahlhausen this is so sweet! Next step will be to write the script to keep track of number of downloads and comments. I can't do it this weekend and next one - working on release and will have a workshop- but then the week after that I will do it.

@mdahlhausen
Copy link
Member Author

@mostaphaRoudsari disqus has a post on adding comment counts to a webpage.

@mostaphaRoudsari
Copy link
Member

Thanks @mdahlhausen! I added a new issue so I don't forget it. #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants