-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Glowing Text #6
Comments
Sorry if i'm not formatting these correctly, I haven't used Github much, but where would I be able to find the code for the Retro Terminal code? I can't seem to find the file location. |
It's inside the Windows terminal repository, the https://github.com/microsoft/terminal/blob/main/samples/PixelShaders/Retro.hlsl I think the issue was that the scale was not properly applied. But I could be mistaken since this is basically the first time that I have written any shader that's more than just a color tint 😄 |
I merged There's probably a lot of refinement before I'd commit this to release and you'd have to see how the license for |
@Hammster, check out the crt.hlsl I have in my crt.hlsl with retro.hlsl branch.
I implemented a blur which doesn't cause compile problems, and it can be used with all options turned on including bloom. I still think it needs work and I still prefer the effect of bloom, but it's an available option. This is a screen capture with everything turned on: The only thing still hanging on from retro.hlsl is the scanlines. There isn't much to what is provided from retro.hlsl and I can't think of a better way to write how it works. If you want to take a stab at that, it should be the last thing. |
Hey guys, I did my own shader based on the original crt.hlsl and I added the glow and rgb misalignment. I didn't see @rbeesley 's edit yet, that might be a better implementation. The rgb misalignment I hadn't seen before, but I thought it gives the image another nice retro touch. By scaling the RGB images by slightly different ratios, we can get that ghosting effect where edges of pure white boxes become red on one side and blue on the other. Both effects together In addition I added slight displacement on the scanline, and in my version turned down the warping a bit. Let me know how this looks, I can do a PR. |
@erjadi, looks like an alignment and convergence modifier? If you want to maybe replace the scanline routine on my pr and add this as another option it would probably be easier to merge. Can you control the focus of each electron beam on its own? Definitely a modifier for color CRTs. |
Hey @erjadi , I know this is somewhat old, so sorry for necroing this, but do you mind sharing your configuration (specifically the RGB shift one) if you still have it? Thanks! |
just +1 here @erjadi to see if you could share the config you posted above, it looks awesome! |
Would it be possible to mix this with the Experimental Retro Effects that come preinstalled with windows terminal?
The text was updated successfully, but these errors were encountered: