Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, Can we support more language? #210

Open
uiosun opened this issue Dec 15, 2022 · 4 comments
Open

Hi, Can we support more language? #210

uiosun opened this issue Dec 15, 2022 · 4 comments

Comments

@uiosun
Copy link

uiosun commented Dec 15, 2022

I want player game at my home language (chinese for me), but not has i18 module?

If we support translate, has some work need? is hard?

@Grokmoo
Copy link
Owner

Grokmoo commented Feb 3, 2023

Unfortunately this is quite a lot of work. We would first need to factor out all of the strings we are displaying into some i18n system - this would include many places not just in the rust code but in scripts and dialog as well. Then, the actual translation work could start.

@uiosun
Copy link
Author

uiosun commented Feb 5, 2023

@Grokmoo Hi, thank you and your reply.

If I want to do that (i18 module), I can submit PR? (I don't join any open source project, so, lacking experience, sorry).

Init i18 functional, and step to step do that is gradual plan, so first, we only need translate a part english word and can test it, is better? <- only I think.

@Grokmoo
Copy link
Owner

Grokmoo commented Feb 8, 2023

Yes, I'm happy to review any PRs. However, I should stress that this is definitely a large undertaking.

The first step would be to setup an i18n module that can load strings from a file. This would need to be done in a way that integrates with sulis's asset loading - probably from another asset folder type, i.e. translations as a new YamlResourceKind. This would enable the translations to work with mods / overrides in the same manner as the other assets.

@uiosun
Copy link
Author

uiosun commented Feb 9, 2023

"integrates with sulis's asset loading" / "translations to work with mods / overrides"

And assert import or export to common struct -- like json / xml, them can use to Transifex or other.

Understand, I will read relational code in sulis's project, and reply my question or program design.

Good nice day for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants