Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion with Asher :) #1

Open
MatthewVita opened this issue Dec 5, 2017 · 3 comments
Open

Discussion with Asher :) #1

MatthewVita opened this issue Dec 5, 2017 · 3 comments
Assignees

Comments

@MatthewVita
Copy link
Member

MatthewVita commented Dec 5, 2017

@jesdynf,

Per your question about the changes to the Dockerfile, there were a lot of changes so that

a) all of the security/prod hardening stuff was removed (don't need SSL for development, for instance)
b) the system is git pulled from dev tip to build and then the code on the host is mounted in via a docker compose volume

Please take a look and give me feedback. There's still cleanup work to do (can't figure out how to rm -rf /var/www/localhost/htdocs/openemr_for_build after the build / copying is done. Would love to have /var/www/localhost/htdocs/openemr as the WORKDIR). Would also like a motd around not using this for production... just for local dev convenience.

Once this is done, I'd like to get it in the devops repo and on docker hub. It will be featured as a primary dev reference and the README will be filled with goodies :)

Okay, enough of my chatter... please take a look and start the conversation!

@bradymiller
Copy link

I am not @jesdynf :)
But recommend Alpine 3.6 (can see that there are several differences for 3.6 in the 5.0.1 Dockerfile https://github.com/openemr/openemr-devops/blob/master/docker/openemr/5.0.1/Dockerfile ). OpenEMR 5.0.1-dev now basically works well with PHP 7.1, so can use Alpine 3.6 now.

@MatthewVita
Copy link
Member Author

Hey, you're not Asher!

Sounds good. Will update it.

BTW, I lied to you. Our git woes will not be solved by this solution. Folks will have the same problems as they do now with checking in sqlconf, template caches, and the like. :/ :/ :/

@MatthewVita
Copy link
Member Author

Can't get around it, despite a few approaches. Just going to need to create a video or something along those lines with our new and shiny YouTube channel when we launch dev.open-emr.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants