Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete provenance in output of NIRI's makeProcessedBPM recipe #440

Open
KathleenLabrie opened this issue Jul 5, 2023 · 0 comments
Open
Labels
bug 🐛 Something should be working but it isn't component - infrastructure recipe_system and any other core functionality severity-routine Needs to be fixed urgency-medium Somewhat normal urgency

Comments

@KathleenLabrie
Copy link
Contributor

The NIRI makeProcessedBPM requires a list of flats and a list of short darks. In the output BPM, the PROVENANCE table shows the flats but it does not show the darks. It seems to be related to the fact that the darks are transferred to a stream.

The PROVENANCE table says that the provenance on the flats was added by prepare. prepare saw the darks confirmed that , the darks were sent to a stream much later. So, somehow, the info about the darks gets removed. I had a quick look at the code and couldn't really figure out how to fix that.

To reproduce quickly, download this debug package: https://drive.google.com/file/d/1l031lwA-aNU6DwmMTjK3s9nzYi0Y6GMU/view?usp=sharing

Then run reduce @flats.lis @darks1s.lis -r makeProcessedBPM.

To inspect the PROVENANCE table:

$ python
>>> import astrodata, gemini_instruments
>>> ad = astrodata.open('N20160102S0373_bpm.fits')
>>> ad.PROVENANCE
@KathleenLabrie KathleenLabrie added bug 🐛 Something should be working but it isn't severity-routine Needs to be fixed urgency-medium Somewhat normal urgency component - infrastructure recipe_system and any other core functionality component - calibration Calibration handling systems and removed component - infrastructure recipe_system and any other core functionality component - calibration Calibration handling systems labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something should be working but it isn't component - infrastructure recipe_system and any other core functionality severity-routine Needs to be fixed urgency-medium Somewhat normal urgency
Projects
None yet
Development

No branches or pull requests

1 participant