Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test coverage for the API project #1351

Open
terrazoon opened this issue Oct 1, 2024 · 1 comment
Open

fix test coverage for the API project #1351

terrazoon opened this issue Oct 1, 2024 · 1 comment
Assignees

Comments

@terrazoon
Copy link
Contributor

terrazoon commented Oct 1, 2024

the API project test coverage was ignoring all code in notifications-utils. Previously we had a separate notification-utils project in GitHub that ran its own tests. Now that notifications-utils is integrated into notifications-admin, we should run coverage on notifications-utils.

The API project was also counting coverage against all code under tests/, which makes no sense.

When we run coverage properly (ignore migrations and tests, count everything else), it turns out we only have 91% coverage. We need to bring this back up to 95%.

@terrazoon terrazoon converted this from a draft issue Oct 1, 2024
@terrazoon terrazoon self-assigned this Oct 1, 2024
@terrazoon terrazoon moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Oct 2, 2024
@terrazoon
Copy link
Contributor Author

Brought it up from 91 to 93 for this sprint (Sleipnir). Putting it back in queue to finish next sprint

@terrazoon terrazoon moved this from 🏗 In progress (WIP: ≤ 3 per person) to ⬇ Up-Next in Notify.gov product board Oct 3, 2024
@terrazoon terrazoon moved this from ⬇ Up-Next to 🏗 In progress (WIP: ≤ 3 per person) in Notify.gov product board Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress (WIP: ≤ 3 per person)
Development

No branches or pull requests

1 participant