Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace font awesome arrow with USWDS arrow icon #328

Open
mejiaj opened this issue Sep 1, 2022 · 0 comments
Open

Replace font awesome arrow with USWDS arrow icon #328

mejiaj opened this issue Sep 1, 2022 · 0 comments
Assignees
@nick-mon1

Comments

@mejiaj
Copy link
Contributor

mejiaj commented Sep 1, 2022 •
edited
Loading

We're loading a font awesome stylesheet for the arrow on the Explore → banner

image

digitalgov-pra/_includes/styles.html

Line 8 in 081567b

<link rel="stylesheet" href="https://use.fontawesome.com/releases/v5.7.2/css/all.css" integrity="sha384-fnmOCqbTlWIlj8LyTjo7mOUStjsKC4pOpQbqyi7RrhN7udi9RwhKkMHpvLbHG9Sr" crossorigin="anonymous" />

digitalgov-pra/_includes/digital.html

Line 4 in 081567b

<a href="https://digital.gov/resources" class="text-white text-no-underline">Explore <i class="fas fa-arrow-right margin-left-1"></i></a>

This seems to be the only case where a font awesome icon is used. Let's reduce dependencies and improve performance by removing this and using the USWDS arrow icon instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nick-mon1 nick-mon1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mejiaj @nick-mon1