Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Material You] "Select a folder" dialog - directory info row uses wrong color #208

Open
7 tasks done
min7-i opened this issue Apr 19, 2024 · 5 comments · May be fixed by FossifyOrg/Commons#48
Open
7 tasks done

[Material You] "Select a folder" dialog - directory info row uses wrong color #208

min7-i opened this issue Apr 19, 2024 · 5 comments · May be fixed by FossifyOrg/Commons#48
Labels
bug Something is not working

Comments

@min7-i
Copy link

min7-i commented Apr 19, 2024

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.1.3

Affected Android/Custom ROM version

Android 14 / GrapheneOS

Affected device model

Google Pixel 6a

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

  1. Make sure you're using the Material You theme.
  2. Select an image.
  3. In the overflow menu, choose "copy to" or "move to".
  4. Select the "Choose a folder" option.
  5. Check the color of the directory info row.

Expected behavior

The background color of the directory info row matches the background color of the rest of the dialog.

Actual behavior

The background color of the directory info row is different than the background color of the rest of the dialog:

Screenshots/Screen recordings

No response

Additional information

No response
@min7-i min7-i added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Apr 19, 2024
@Aga-C Aga-C added enhancement New feature or request and removed bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Apr 19, 2024
@min7-i
Copy link
Author

min7-i commented Apr 19, 2024

Sorry, I forgot to mention that the correct color was used in previous versions, e.g. in 1.1.2. That's why I considered it a bug and not an enhancement.

@Aga-C Aga-C added bug Something is not working and removed enhancement New feature or request labels Apr 19, 2024
@connyduck
Copy link
Contributor

I think this is easily fixed by removing the background here, I'm just worried that might break something else. Which tests can I do to ensure that is not the case?

@naveensingh
Copy link
Member

@connyduck that's for the first breadcrumb's background, not the whole horizontal scroll view. Applying the proper background color on the view itself should fix it but I haven't checked what's caused this in the first place. Probably some dependency update.

@connyduck
Copy link
Contributor

@naveensingh No. Maybe it should be the background of the first breadcrumb, but if you look at the code closely you will notice that this is Resources which doesn't have a background setter, and neither has the outer this which is ItemBreadcrumbFirstBinding. So the background is actually set to the whole Breadcrumbs class.

This commit introduced the problem. Before the refactoring this actually was the view of the first breadcrumb.

Can I send a PR with a fix?

@naveensingh
Copy link
Member

Right, I only had a quick peek.

It should be root.background instead of just background. You are welcome to raise a PR but do test the change once with different light/dark theme variants.

@connyduck connyduck linked a pull request May 1, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is not working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

improve breadcrumbs connyduck/Fossify-Commons
4 participants
@connyduck @naveensingh @Aga-C @min7-i