-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External URL validation is too strict #1068
Comments
Then you can just keep this field empty? Jellyseerr will use the internal URL |
The internal URL is based on the containers' hostnames, which are not the same as the external hostname. |
For the time being, you can set it directly on settings.json file |
It's easy to do a fix for this one, but I'm afraid this would cause less experienced people to fill in wrong values. |
We could add a stricter validation here where it allows: Sounds like regex hell though. We could look into if yup validator allows such a thing |
In this case we can just allow everything starting with |
Yes and no. What if its http://@hdhskl:!@ |
Yes, I mean just a regular URL |
Default url validation from the Yup module doesn't allow URLs like "http://custom-host", while it is a correct value for an external URL. fix #1068
Description
My Jellyfin, Radarr and Sonarr are all accessed on
http://melorae
within my local network. But attempting to enter this in the "External URL" doesn't work because "You must provide a valid URL".Version
2.0.1
Steps to Reproduce
Settings -> Jellyfin -> External URL
enter any domain without a suffix
Screenshots
No response
Logs
No response
Platform
desktop
Device
PC
Operating System
Ubuntu 24 (server), Windows 10 (client)
Browser
Firefox
Additional Context
No response
Code of Conduct
The text was updated successfully, but these errors were encountered: