Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c:is_cold tag is missing c:is_cold/end #4150

Open
PaintNinja opened this issue Oct 8, 2024 · 0 comments
Open

c:is_cold tag is missing c:is_cold/end #4150

PaintNinja opened this issue Oct 8, 2024 · 0 comments

Comments

@PaintNinja
Copy link

PaintNinja commented Oct 8, 2024

While working on Forge's implementation of the de-facto partial c: tags across loaders, we noticed a discrepancy between Neo and Fabric for the c:is_cold tag and believe it may be an oversight. MinecraftForge/MinecraftForge#9955 (comment)

For c:is_hot, it contains the c:is_hot/overworld and c:is_hot/nether variants:

getOrCreateTagBuilder(ConventionalBiomeTags.IS_COLD)
.addTag(ConventionalBiomeTags.IS_COLD_OVERWORLD);

However, c:is_cold does not contain the c:is_cold/end variant:

getOrCreateTagBuilder(ConventionalBiomeTags.IS_HOT)
.addTag(ConventionalBiomeTags.IS_HOT_OVERWORLD)
.addTag(ConventionalBiomeTags.IS_HOT_NETHER);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant