Skip negative cell indices when packing coefficients #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
RemDelaporteMathurin
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Tested it locally with this script and everything runs fine. The SEGV I was previously having doesn't appear anymore.
Thanks @jorgensd ! 🎉
|
@jpdean do you have time to look at this? |
garth-wells
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
@jorgensd Is there a change we could make to avoid this check? I haven't looked at the details for a long time . . .
schnellerhase
pushed a commit
to schnellerhase/dolfinx
that referenced
this pull request
Sep 11, 2024
* Skip negative cell indices when packing coefficients * Simplify MPI send recv * Ruff formatting * Small logic simplification --------- Co-authored-by: Garth N. Wells <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #3260.
If one has multiple disjoint sub-meshes in a variational form, then restricting packing by
enabled_coefficientsper integral type is not sufficient.Example follows:
Divide an interval mesh in three disjoint cell sets (left, center, right).
If we want to create a coupling from the right submesh to the parent mesh at the interface between center and right),
we can add an integral
(u_parent("+")-u_parent("-"))*v_right("+")*dS(interface_rc)to our variational form.Similarly we could do the same for the left integral:
(u_parent("+")-u_parent("-"))*v_left("+")*dS(interface_lc).However, now both coefficient v_right and v_left will be packed for all facets marked with either interface_rc or interface_lc, which leads to undefined behavior (segfaults).
The following PR adds a check after fetching the cell during packing, and only packs coefficients if the cell index is positive.
Issue reported by @RemDelaporteMathurin when trying to adapt my example: https://gist.github.com/jorgensd/8a5c32f491195e838f5863ca88b27bce#file-problem-py to multiple surfaces.