Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PETSc SNES API in dolfinx.xxxx.petsc namespace #3511

Open
jorgensd opened this issue Nov 15, 2024 · 1 comment
Open

PETSc SNES API in dolfinx.xxxx.petsc namespace #3511

jorgensd opened this issue Nov 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@jorgensd
Copy link
Member

Describe new/missing feature

As PETSc SNES has way more features than our newton solver, and is not trivial to implement, it would be best to move the current implementation out of the tests and into the dolfinx.xxx.petsc namespace.

Suggested user interface

No response

@jorgensd jorgensd added the enhancement New feature or request label Nov 15, 2024
@jhale
Copy link
Member

jhale commented Nov 15, 2024

It would be good to add a SNESNonlinearProblem class near the existing NonlinearProblem class with a clear docstring describing correct use with SNES:

https://github.com/FEniCS/dolfinx/blob/main/python/dolfinx/fem/petsc.py#L893

Even NonlinearProblem docstring could be improved; it's unclear that the only class in DOLFINx that can accept it is NewtonSolver. I'm also unsure whether the NewtonSolver should share its solution state with F and J - @jorgensd does not agree with me on this point (simplicity).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants