Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dataset clone #405

Open
1 task
tokland opened this issue Aug 8, 2019 · 0 comments
Open
1 task

Refactor dataset clone #405

tokland opened this issue Aug 8, 2019 · 0 comments
Assignees

Comments

@tokland
Copy link
Collaborator

tokland commented Aug 8, 2019

Currently, when you clone a dataset, the name is the same than the original dataset. Furthermore, if the field name is not focused, the uniqueness validation is not run (since asyncValidations only run on field change), so we end up with datasets with the same name.

Proposal:

  • 1) On clone, set name ${oldName} Clone${n}, where n is calculated (with a request to the DB) so the proposed name is guaranteed to be unique.
@tokland tokland self-assigned this Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant