New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible improvements to solver base classes #246

Open

oparry-ukaea opened this issue Jun 20, 2024 · 0 comments

Contributor

oparry-ukaea commented Jun 20, 2024 •

edited

Loading

Allow multiple ParticleGroups in PartSysBase?
Fields are restricted to all have the same number of quad points. Should at least make this check optional, but probably better to remove it altogether
load_params() copies nektar's unfriendly pattern of relying on the developer to call the parent implementation in the override - find a nicer way to do it
prefix header guard macros (_NESO*?) to avoid clashes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment