-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3D HW #220
Draft
oparry-ukaea
wants to merge
18
commits into
main
Choose a base branch
from
feature/3DHW
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
3D HW #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oparry-ukaea
force-pushed
the
feature/3DHW
branch
from
December 4, 2023 12:53
ea72b3a
to
c218cfe
Compare
Open
…f for some reason.
oparry-ukaea
force-pushed
the
feature/3DHW
branch
from
February 21, 2024 16:32
f493384
to
acba2d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add 'true 3D' HW equation system to the H3LAPD solver.
Fixes #214
Type of change
Please delete options that are not relevant.
Testing
HWTest.3DHWGrowthRates (in test/integration/solvers/H3LAPD/test_H3LAPD.cpp)
Runs the H3LAPD solver with the "HW3DSystem" equation system for a small number of steps with periodic BCs on all sides.
Particle number is set to 0.
Tests that growth rate of energy and enstrophy match analytical expected rates (see equations 8 and 9 of this ref or the same equation numbers in Hasegawa & Wakatani, 1983 for similar calculations).
Passes iff rates match to a tolerance of 5e-3 AND the solver returns 0.
Test Configuration:
OS: Ubuntu 22.04
Compiler: GCC 11.3.0 / OneAPI v2022.1.0
SYCL implementation: Hipsycl v0.9.2 / DPC++ v2022.1.0
MPI details: MPICH v4.0.2
Hardware: CPU (Intel Alder Lake)
Checklist:
clang-format
against my*.hpp
and*.cpp
changescmake-format
against my changes toCMakeLists.txt