Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our software engineering practices #10

Open
tommylees112 opened this issue May 14, 2019 · 4 comments
Open

Our software engineering practices #10

tommylees112 opened this issue May 14, 2019 · 4 comments

Comments

@tommylees112
Copy link
Contributor

  1. Run pytest and mypy locally before committing to github.

  2. Each function should have a descriptive name and perform one task. An exception is potentially pipeline type functions that run the process functions in a particular order

  3. Docstrings are standardized:

  • only have docstrings for functions the users will interact with
  • A description at the beginning
  • Input arguments (or the class attributes)
  • What the function returns
  1. Using static typing wherever possible
@tommylees112
Copy link
Contributor Author

(all credit to @gabrieltseng - more a note to self than anything else)

@tommylees112
Copy link
Contributor Author

Running pytest:

into the command line in the project root just type:

$ pytest

If there are issues with flake8 see here)

@tommylees112
Copy link
Contributor Author

Running mypy

$ mypy src

@tommylees112
Copy link
Contributor Author

When do you know if you're ready for a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant