Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can our transition from timetable list to detail item be smoother? #601

Open
takahirom opened this issue Aug 18, 2024 · 8 comments
Open

Comments

@takahirom
Copy link
Member

I'm not sure if it's due to the debug build, but we could improve the performance.

@toastmeister1
Copy link

🙋‍♂️

@toastmeister1
Copy link

How about making this change? I think it might reduce some lag.
I tried animating only the necessary components instead of the entire container, and added a fade-in effect for a smoother transition.

AS-IS TO-BE
asis.mp4
tobe.mp4

@takahirom
Copy link
Member Author

If we could review Material 3 transitions, that would be great.
https://m3.material.io/styles/motion/transitions/applying-transitions

@toastmeister1
Copy link

toastmeister1 commented Aug 19, 2024

Got it, I'll try it out.
Thanks for the tip :)

@takahirom
Copy link
Member Author

Anyway, Assigned 👍

@takahirom
Copy link
Member Author

This style might be what we're going for, but I'm not sure if we can animate it smoothly.
https://m3.material.io/styles/motion/transitions/applying-transitions#292e3d1a-4c3c-457d-a034-bade548a99f0

@toastmeister1
Copy link

I'm sorry for the delayed response.
Despite trying several approaches, I'm struggling to get satisfactory performance in Debug mode when using SharedElements. Is the main reason for prioritizing performance in Debug mode for a conference app the difficulty in releasing it? Because of this, I'm thinking about exploring other animations that might be more performant. 🤔

@takahirom
Copy link
Member Author

I think so too. That's why we assigned this issue a low priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants