fix JSONPath inconsistencies #1266
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're not looking to support RESP3 at this stage. Let's stick with RESP2. Is RESP3 support a blocker in any way? |
|
Nope, definitely not a blocker. |
In that case we can remove the related code and limit this PR to just the jsonpath changes. |
|
Looks like the tests and linter are failing, could you please take a look? Also, is this PR ready for review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JyotinderSingh.
Sorry for the delay. I was busy with something urgent at work and couldn't give enough time.
Have a look at this PR. It's not completed yet but good portion of it is completed. Unfortunately, I am unable to find how to enable the resp3 protocol.
Also, in the Data Link shared the multi path examples seems incorrect in the array example.
Currently, I am testing it on my end but since certain parts such as RESP3 and custom formats are pending I am not asking for a merge yet.
I wanted to also open up a discussion on certain outputs that Redis returns such as for example "accessing negative index on out of bounds for an arrray example", etc.
Should we be following that as I believe we should instead return error for such cases instead of nil or the way redis handles.
Fixes #1002