Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strike balance between linter picking up problems in the code and being overly verbose #8

Open
jcfreeman2 opened this issue Jun 2, 2022 · 0 comments · May be fixed by #9
Open

Strike balance between linter picking up problems in the code and being overly verbose #8

jcfreeman2 opened this issue Jun 2, 2022 · 0 comments · May be fixed by #9

Comments

@jcfreeman2
Copy link
Collaborator

The two failure modes are (1) the linter misses important mistakes (copying when it's unnecessary, using something after it's been moved, etc.) and (2) the linter complains about stuff we don't care about ("narrowing conversions" that aren't actually narrowing, etc.). We need to find the right balance.
@dingp dingp linked a pull request Jun 2, 2022 that will close this issue
Johnfreeman/linting spack support #9
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Johnfreeman/linting spack support DUNE-DAQ/styleguide
1 participant
@jcfreeman2