JCF: Issue #534: deal with loopbacks in application plots #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem this commit deals with is basically, if you have a module which subscribes on the network to a wildcarded message (say "msg_.*") and another module in the same application which sends a version of message that matches the wildcard (say "msg_A") out onto the network, then how do you plot that? Previously, when plotting, the logic in the plotter didn't care about whether a message was sent onto the network. So it was drawing a connection between the modules making it look as if they communicated via a queue. With this commit, if we're plotting an application, a message gets correctly represented as being sent out over the network, and as being received from the network (with the usual "X" and "O" to represent "region outside of this diagram").
eflumerf
approved these changes
Nov 6, 2024
|
|
bieryAtFnal
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
In the new version of the MLT-focussed view, at first it wasn't obvious to me what I was seeing. However, after re-rereading Eric's comments and looking at it a little more, I figured it out.
In the end, I agree that this is an improvement. It will probably be good to educate people that sometimes we need to look for fully-specified outputs (e.g. X = tcs_random-tc-generator) that match wildcard inputs (e.g. O = tcs_*) to get all of the connections clear...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem this commit deals with is basically, if you have a module which subscribes on the network to a wildcarded message (say "msg_.*") and another module in the same application which sends a version of message that matches the wildcard (say "msg_A") out onto the network, then how do you plot that?
Previously, when plotting, the logic in the plotter didn't care about whether a message was sent onto the network. So it was drawing a connection between the modules making it look as if they communicated via a queue. With this commit, if we're plotting an application, a message gets correctly represented as being sent out over the network, and as being received from the network (with the usual "X" and "O" to represent "region outside of this diagram").