Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify format of UserAgent-Header #273

Open
ubamrein opened this issue Nov 2, 2020 · 0 comments · Fixed by #278
Open

Specify format of UserAgent-Header #273

ubamrein opened this issue Nov 2, 2020 · 0 comments · Fixed by #278

Comments

@ubamrein
Copy link
Contributor

ubamrein commented Nov 2, 2020

With the new release, the android sdk changed the header by appending the version of the used EN-Framework. Currently, we are checking for exactly 5 parts as can be seen here:

For now, we should change the condition to >=5, to account for the added properties.

I think ultimately we should sit together with the app-sdk people and define a specific format (e.g. a map) to make the parsing more robust to changes and additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant