Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSI: 0.0000000 and MFI: 0.0000000 trigger false notifications #370

Open
opoloko opened this issue Nov 19, 2019 · 3 comments
Open

RSI: 0.0000000 and MFI: 0.0000000 trigger false notifications #370

opoloko opened this issue Nov 19, 2019 · 3 comments

Comments

@opoloko
Copy link

opoloko commented Nov 19, 2019

Hi

as this is a Docker and so quite inconvenient to modify, could you please fix the problem (already flagged) of signals values 0.00000000 triggering alerts??

Should be easy enough to in notification.py to make notification false if the value is 0.00000000 because that means obviously that the analysis or data were not enough or valid.

Could you please fix it so we can pull the updated Docker image?

@laliux
Copy link
Collaborator

laliux commented Nov 19, 2019

Hey @opoloko

That is fixed, but still in develop branch. Check the REAME there:

https://github.com/CryptoSignal/crypto-signal/blob/develop/README.md

Best

@opoloko
Copy link
Author

opoloko commented Nov 20, 2019

Hi thanks, I tried the devel but I still get same problem on MFI indicator: trigger HOT when value is 0.00

[5m / 14] binance-ALGO/BTC-mfi-0 is hot! ({'mfi': '0.00'})

@opoloko
Copy link
Author

opoloko commented Nov 24, 2019

Hi

the crossovers as well triggered for opening/closing value of 0.00...it seems generally speaking nothing should be triggered for a 0.00 (I can't think of any indicator going down to 0.00000000 while instead that is more a sign of data not arrived).

Is the dev version fixed also for other indicators? Getting lots of false positives because of that :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants