Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataType error when computing dataset logits in DER Task-Incremental scenario #1657

Open
guilhermegog opened this issue Jul 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@guilhermegog
Copy link

When training a multi-head module with DER there seems to be a bug as the compute_dataset_logits() function is expected to return a tensor, but seemingly creates a dictionary.

To replicate, simply run the multihead.py with the DER strategy.

I tried fixing the problem by adding a check on the aforementioned function to see if a dictionary is being generated as the output of the model and to convert the dictionary values into the desired data type (lines 48 to 52 on der.py):

if(isinstance(out,dict)):
  out = out.values()
  out = list(out)[0]

but sometimes this conversion yields tensors with seemingly random sizes ([128,6] or [128,9] instead of the expected [128,10])

@guilhermegog guilhermegog added the bug Something isn't working label Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant