-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br-co-25 check does not match description #386
Comments
I don't see an issue with the current statement. The logical OR gives that at least one (or both) have be present for the rule to pass. |
It did confuse me, since other rules explicitly mention that providing both options is valid:
Furthermore either + or in the English language gives the statement an exclusive character (one of the options not both). |
can it it be a problem for the receiver, if |
The Payments terms is often used together with the due date. I would say this also was the intention from start. See the definition from the EN: A textual description of the payment And usage note: If the wording BR-CO-25 is perceived as confusing (and I agree that the it can be written better), then I propose that this is forwarded for an editorial fix in the next revision of the EN16931-1. |
I understand your problem, but it is necessary to allow multiple payment terms that contain different due dates: Example in several states there exist conditions where the amount to be paid is dependent on the time of payment. It may be a discount or a surcharge. Unfortunately, today, the EN16931 does not support those kinds of terms in its semantics. The syntax bindings and validation rules do not reflect this, although the two syntaxes would be capable of providing the information in a structured way. Example for multiple payment terms with different due dates: Line 1: 1000.00 EUR payable within 30 days (until 2024-07-23) without deductions. Or (common in some other countries) |
It shall be interpreted as both are allowed. Changing the text of the current version of the EN16931-1 as suggested is not possible at this moment. It will however be withheld for the Revision. |
https://docs.peppol.eu/poacc/billing/3.0/rules/BR-CO-25/
The rule should actually test if either (exclusive)
DueDate
orNote
is present. However, it also passes if both are present.Does the description or the test need any adaptation? Maybe something like:
The text was updated successfully, but these errors were encountered: