-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify usage of repository #12
Comments
This repo is currently intended as a issues-only repo for discussion of large-ish changes to Cantera. Check out #9 and the files @speth has added there. The idea is not to have any code in this repo, only discussion. This repo is inspired by NumPy Enhancement Proposals (which are in turn inspired by PEPs): https://numpy.org/neps/index.html |
Sounds good. This repo's README.md file is probably work in progress, but hopefully will make this clear eventually. |
Yes, see the README in #9 |
Clearly, work in progress! :+1 |
At the moment, it is not clear how this repository will be used: will this be a fork of Cantera, that can be rebased/merged in the usual manner, or is this meant to be a repository that collects code compiled against core cantera (e.g. similar to
ctwrap
).Specifically, I have two PR's in the main repository that are stubs (Cantera/cantera#692 and Cantera/cantera#694), which could arguably be moved here as neither is ready to be merged (they depend on ongoing work summarized in issue #11). What would be the proposed mechanism for accomplishing this (i.e. moving the stubs here), while still being able to compile and test as usual? (I admittedly may not be fully aware of the entirety of git features).
The text was updated successfully, but these errors were encountered: