Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giving a dark mode to the website #152

Open
aayushsrivastava9760 opened this issue Oct 14, 2021 · 8 comments
Open

Giving a dark mode to the website #152

aayushsrivastava9760 opened this issue Oct 14, 2021 · 8 comments
Labels
enhancement New feature or request

Comments

@aayushsrivastava9760
Copy link
Contributor

I want to work on this one. Kindly assign it to me.

@shubhanshu02
Copy link
Member

Can you elaborate how are you planning to accomplish this task?

@aayushsrivastava9760
Copy link
Contributor Author

I was thinking of adding a toggle button at the top and then adding some classes based on dark-mode for buttons, texts, and background . Based on the toggle selection, classes should be changed.

@shubhanshu02
Copy link
Member

I guess this part seems too big. But you are welcome if you want to try it out.

@shubhanshu02 shubhanshu02 added the enhancement New feature or request label Oct 15, 2021
@aayushsrivastava9760
Copy link
Contributor Author

Yes, @shubhanshu02 bhaiya, I would like to try this one out.

@aayushsrivastava9760
Copy link
Contributor Author

@shubhanshu02 bhaiya , can we use 'atomize' for the theme toggling as it has ThemeProvider or will I have to go with a different library .

@shubhanshu02
Copy link
Member

Not sure about that. I can see the ThemeProvider from atomize is already used in the _app.tsx.

<ThemeProvider theme={theme}>
<StyleReset />
<AuthProvider>
<Header />
<div
style={{ paddingTop: "88px", minHeight: "100vh" }}
className="d-flex flex-column justify-content-between"
>
<Component {...pageProps} />
<ToastContainer />
<Footer />
</div>
</AuthProvider>
</ThemeProvider>

Maybe someone from the Hackalog team can say better?? @COPS-IITBHU/2020

@aayushsrivastava9760
Copy link
Contributor Author

so may i go with some other package for the same .

@shubhanshu02
Copy link
Member

whichever seems more feasible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants