Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No v1.1.6 on conda, and only prebuilt for MacOS (no source) on pypi #663

Open
eachanjohnson opened this issue Oct 9, 2024 · 3 comments
Open

Comments

@eachanjohnson
Copy link
Contributor

Describe the bug
I could not install the latest v1.1.6 release on Linux using either conda install umi_tools=1/1/6 or pip install umi_tools==1.1.6. Installing from GitHub works with pip install git+https://github.com/CGATOxford/[email protected].

To Reproduce
Try conda install umi_tools=1.1.6.

Expected behavior
To be able to install the v1.1.6 release.

Environment

  • OS: Linux
  • UMI-tools version 1.1.6
  • How was UMI-tools installed (e.g pip/conda etc): N/A

Additional context
It looks like 1.1.6 isn't on the conda index at all, and only pre-built MacOS binaries and no source are available on pypi.
Screenshot 2024-10-09 at 17 09 12
Screenshot 2024-10-09 at 17 09 36

Additional context: thanks so much for continuing to maintain this great suite of tools! 🙇

@TomSmithCGAT
Copy link
Member

Thank you for catching this @eachanjohnson! That'll teach me for rushing through a random blog post to remind myself how to upload packages to pypi 🤦

As suggested in the blog, I ran python setup.py bdist_wheel, when I should of run python setup.py sdist, hence the lack of source code in the upload. That's been rectified now.

I did note previously that bioconda didn't immediately update umi_tools, but figured I was just being too impatient and forgot to check back. Previously, the bioconda bot picked it up fairly quickly (within a few hours if I remember right). I'll check again tomorrow whether uploading the source is sufficient to get the bot to pick it up. If not, I'll make a manual PR. I'll leave this open until bioconda has the latest version too.

@eachanjohnson
Copy link
Contributor Author

I have a GitHub action for uploading to pypi when a release is made. I could make a PR perhaps tomorrow to include it if helpful.

@TomSmithCGAT
Copy link
Member

That would be really useful, thank you 🙏

I looked into using a Github action for automating the uploading, but I can't remember where I got stuck. Don't see any reason why a generic action shouldn't work perfectly fine here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants