Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PR benchmark comment readability #155

Open
gavlyukovskiy opened this issue Jul 16, 2024 · 0 comments
Open

Improve PR benchmark comment readability #155

gavlyukovskiy opened this issue Jul 16, 2024 · 0 comments

Comments

@gavlyukovskiy
Copy link
Collaborator

gavlyukovskiy commented Jul 16, 2024

As we have more becnhmarks its getting harder to quickly dissect the results of the PR. We'd like to improve that.

One idea would be to use diff against the results, for example:

Benchmark                                                             (characters)  (jsonPath)  (jsonSize)  (keyLength)  (maskedKeyProbability)  (numberOfTargetKeys)   Mode  Cnt           Score        Error   Units
+ BaselineBenchmark.countBytes                                             unicode         N/A         1kb          N/A                     0.1                   N/A  thrpt    4     2606372.497 ±  97833.565   ops/s
- BaselineBenchmark.countBytes                                             unicode         N/A         1kb                                  0.1                        thrpt    4     2602928.830 ± 150097.202   ops/s

or a markdown table.

We could also use https://github.com/benchmark-action/github-action-benchmark to do that

@gavlyukovskiy gavlyukovskiy changed the title Improve MR benchmark comment readability Improve PR benchmark comment readability Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant