Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming this integration #62

Open
BenPru opened this issue Jan 15, 2023 · 4 comments
Open

Renaming this integration #62

BenPru opened this issue Jan 15, 2023 · 4 comments

Comments

@BenPru
Copy link
Contributor

BenPru commented Jan 15, 2023

I am currently trying to process and provide my further development of this integration as a ha core integration.
We had already discussed renaming this integration in the past.
Do you still want to tackle this? luxtronik_legacy or similar?

@AJediIAm
Copy link

If I recall correctly, HA will prioritize an internal integration over a HACS integration with the same name. Renaming this integration will ensure existing users can choose which integration they want to use, but it's not blocking to add the luxtronic core integration.

@BenPru
Copy link
Contributor Author

BenPru commented Jan 15, 2023

If I recall correctly, HA will prioritize an internal integration over a HACS integration with the same name. Renaming this integration will ensure existing users can choose which integration they want to use, but it's not blocking to add the luxtronic core integration.

Okay, good to know.

@Bouni
Copy link
Owner

Bouni commented Jan 16, 2023

As I mentioned in @BenPru 's PR home-assistant/core#59788 (comment) I'll happily rename this integration in favor of his if it gets merged into core to avoid misunderstandings.

Maybe we should try to name it luxtronik2 instead of luxtronik because I have a request of someone if I could help create an integration for a Luxtronik1 controller. The underlying protocoll is completely different from the one used by luxtronik2 controllers so supporting both in one integration is pointless in my eyes ...

Let me know what you think!

@BenPru
Copy link
Contributor Author

BenPru commented Jan 16, 2023

luxtronik2

This conflicts with my current integration. 😵‍💫
But the only reason to install your luxtronik and my luxtronik2 at the same time is for different heatpumps in the same network.
And this can handle my new integration out of the box.
The only thing... I currently working to detect a luxtronik2 integration installation, import two config values (CONF_CONTROL_MODE_HOME_ASSISTANT + CONF_HA_SENSOR_INDOOR_TEMPERATURE), set the sensor unique id to luxtronik2 and disable the legacy luxtronik2 integration.

In the normal case I use %sensor_domain%.luxtronik_%serial_number%_%name% (e.g. climate.luxtronik_123456-047_domestic_water). But if I detect a legacy luxtronik2 integration I set this to %sensor_domain%.luxtronik2_%name% (e.g. climate.luxtronik2_domestic_water) for the first heatpump to prevent the sensor history.

Long talking, short message: luxtronik2 is possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants