Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Support for "venantius/ultra" lein plugin #207

Closed
tamizhvendan opened this issue Jun 6, 2019 · 6 comments
Closed

[2.0] Support for "venantius/ultra" lein plugin #207

tamizhvendan opened this issue Jun 6, 2019 · 6 comments
Labels

Comments

@tamizhvendan
Copy link
Contributor

Thanks, @PEZ for revamping calva and it looks fantastic!

With this new version, I am unable to use the "venantius/ultra" lein plugin.

profiles.clj

{:repl {:plugins [[venantius/ultra "0.5.4"]]}}

terminal output

> Executing task: /usr/local/bin/lein update-in :dependencies conj "[nrepl \"0.6.0\"]" -- update-in :plugins conj "[cider/cider-nrepl \"0.21.1\"]" -- update-in "[:repl-options :nrepl-middleware]" conj "[\"cider.nrepl/cider-middleware\"]" -- with-profile test repl :headless <

[WARNING] No nREPL middleware descriptor in metadata of #'clojure.tools.nrepl.middleware.render-values/render-values, see nrepl.middleware/set-descriptor!
nREPL server started on port 63347 on host 127.0.0.1 - nrepl://127.0.0.1:63347

After nREPL server started, VSCode is prompting to enter the port to connect to the nREPL server. Entering the port number doesn't connect the server.

Here is the terminal output that I am getting.

--
Start the REPL with the command *Start Project REPL and connect (aka Jack-in)*.
Default keybinding for Jack-in: ctrl+alt+c ctrl+alt+j
Jacking in...
Hooking up nREPL sessions...

If I remove that plugin from the profiles, everything is working as expected.

@bpringe
Copy link
Member

bpringe commented Jun 10, 2019

@tamizhvendan I'm not sure if it's possible to use cider middleware (as Calva does) alongside Ultra. See this in its readme: https://github.com/venantius/ultra#using-cider-alongside-ultra

I may be wrong though. CC @PEZ

@PEZ
Copy link
Collaborator

PEZ commented Jun 10, 2019

It does seem, from that link, that Calva will be quite incompatible with Ultra. However, it also seems like we need some way to specify profiles to exclude with jack-in.

@svdo
Copy link
Contributor

svdo commented Feb 1, 2021

I just came across this issue. I'm not sure what the original poster's use case was, but for me what I would really want to have is the way ultra prints test output, specifically not only the expected and actual, but also the diff. Would that be easier somehow, possibly with another lib that maybe Ultra also uses for this purpose or something? Maybe https://github.com/lambdaisland/deep-diff2, the library that is used by Kaocha.

@bpringe
Copy link
Member

bpringe commented Feb 1, 2021

Without looking more into it atm, I think it would be possible. Maybe even fairly easy to add to the test runner. Please submit a feature request if you'd like. Although, maybe making ultra work with Calva could be simpler, I'm not sure.

@PEZ PEZ removed the enhancement label Feb 10, 2021
@PEZ
Copy link
Collaborator

PEZ commented Mar 18, 2023

I'll be closing this because it is tricky to take action on as it stands. I've heard other people wishing for better test results diffing. If there isn't an issue for that already, please feel invited to file one.

@PEZ PEZ closed this as completed Mar 18, 2023
@bpringe
Copy link
Member

bpringe commented Mar 20, 2023

Here's an issue for that: #1007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants