Some more overmap fixes #2710
Open
Some more overmap fixes #2710
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bokkiewokkie
approved these changes
Sep 13, 2024
Bokkiewokkie
added
Overmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
#2693 adjusts singularities to use the system contents to track affected, but fails to account for the fact not all contents of
system_contentsare overmap objects (as opposed toGLOB.overmap_objects).This PR does similar but safer, while also reinforcing some sanity a bit (current_system was not 100% reliable at being set for anomalies and spawn_ship flooded system_contents with typepaths)
Also makes overmaps firing projectiles a bit less likely to runtime if they are near mapedge or were firing while being moved to nulspace.
This fixes #2701 (Well technically it is a testmerge breaking it but this does that part except without breaking).
Why It's Good For The Game
Fix man good.
Testing Photographs and Procedure
This is tested on local.
Changelog
🆑
code: Singularities now use system contents in a safe way.
fix: Spawn_ship no longer floods system_contents with typepaths.
fix: Overmap firing should be a bit more resilient to turf-related oddities.
/:cl: