Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RBKI termination criteria should use eps<T>, not eps<double>. #69

Open
rileyjmurray opened this issue Apr 23, 2024 · 0 comments
Open

RBKI termination criteria should use eps<T>, not eps<double>. #69

rileyjmurray opened this issue Apr 23, 2024 · 0 comments

Comments

@rileyjmurray
Copy link
Contributor

This line

RandLAPACK/RandLAPACK/drivers/rl_rbki.hh

Line 379 in f8e4226

if(std::abs(R_ii[(n + 1) * (k - 1)]) < std::sqrt(std::numeric_limits<double>::epsilon())) {
gets machine epsilon for double-precision, even when T is something other than double. It should be changed accordingly.
@rileyjmurray rileyjmurray changed the title CQRRP termination criteria should use eps<T>, not eps<double>. RBKI termination criteria should use eps<T>, not eps<double>. Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rileyjmurray