Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README.md files could mention that mvn clean install requires a running docker instance. #185

Open
pawelslowik opened this issue Aug 19, 2022 · 2 comments
Open

README.md files could mention that mvn clean install requires a running docker instance. #185

pawelslowik opened this issue Aug 19, 2022 · 2 comments

Comments

@pawelslowik
Copy link
Contributor

So the first thing a new person sees in this project is a failing Maven build caused by failing tests caused by no docker running in the background. Not a big deal, but mentioning that requirement for building a project in the readme file could give better experience to other users.
@torrespro
Copy link
Contributor

is there right? https://github.com/Backbase/golden-sample-services#required-software

@pawelslowik
Copy link
Contributor Author

pawelslowik commented Aug 19, 2022 •
edited
Loading

Sure, I was expecting it to require docker for runnig, but not for building/running tests, it's not common. Just think it might surprise other users as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@torrespro @pawelslowik