Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create testing data for released weldx versions #651

Open
marscher opened this issue Nov 17, 2021 · 2 comments
Open

create testing data for released weldx versions #651

marscher opened this issue Nov 17, 2021 · 2 comments
Labels
ASDF everything ASDF related (python + schemas) CI tests pytest (and other tests) related

Comments

@marscher
Copy link
Collaborator

To ensure backward-compatibility with previously created files, we should create at one weldx file for each released version.
It would be preferable having a separate repository for these, which could be included as submodule in this repository. This would enable for easier CI operations.

We can use the single_pass_weld schema here, or more fine grained schemas. I guess the more fine grained they are, the easier it would be to spot broken things. However it is not expected for things to break often, so the big schema would be preferable then.

@marscher marscher added CI ASDF everything ASDF related (python + schemas) tests pytest (and other tests) related labels Nov 17, 2021
@CagtayFabry
Copy link
Member

another option would be to run the pytest asdf plugin on old schema files as they include (a lot of) example code with correctly tagged (legacy) versions
I will test if this works as expected (but from now on all legacy schemas will be included in the weldx main repository anyway so this testing method would come for free if feasible 👍 )

@marscher
Copy link
Collaborator Author

Sounds like a feasible solution to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASDF everything ASDF related (python + schemas) CI tests pytest (and other tests) related
Projects
None yet
Development

No branches or pull requests

2 participants